shad0w/pelagia-portal
1
0
Fork 0
Code Issues 6 Pull requests 1 Projects Releases 2 Packages Wiki Activity Actions

Merge pull request 'fix: Add a PO line items units entry for months and year' (#45) from claude/issue-44 into master

Browse source 
Reviewed-on: #45
This commit is contained in:
shad0w 2026-06-20 19:05:08 +00:00
commit 783051933a
2 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
App/components/po/po-line-items-editor.tsx
View file

@ -20,8 +20,11 @@ const UOM_OPTIONS = [
{ value: "mL", label: "mL — Millilitre" },
{ value: "m", label: "m — Metre" },
{ value: "m2", label: "m² — Sq. Metre" },
{ value: "hr", label: "hr — Hour" },
{ value: "day", label: "day — Day" },
{ value: "hr", label: "hr — Hour" },
{ value: "day", label: "day — Day" },
{ value: "week", label: "week — Week" },
{ value: "month", label: "month — Month" },
{ value: "year", label: "year — Year" },
{ value: "lump", label: "lump — Lump Sum" },
{ value: "Ltr", label: "Ltr — Litre (alt)" },
];

19
App/tests/unit/po-line-items-editor.test.tsx
View file

@ -93,6 +93,25 @@ describe("LineItemsEditor — edit mode", () => {
const lastCall = onChange.mock.calls[onChange.mock.calls.length - 1][0] as LineItemInput[];
expect(lastCall[0].gstRate).toBeCloseTo(0.05);
});
it("offers month and year as unit-of-measure options", () => {
render(<LineItemsEditor items={[DEFAULT_ITEM]} onChange={vi.fn()} />);
const selects = screen.getAllByRole("combobox") as HTMLSelectElement[];
const unitSelect = selects.find((s) => s.value === "pc")!;
const values = Array.from(unitSelect.options).map((o) => o.value);
expect(values).toContain("month");
expect(values).toContain("year");
});
it("calls onChange with the selected duration unit", async () => {
const onChange = vi.fn();
render(<LineItemsEditor items={[DEFAULT_ITEM]} onChange={onChange} />);
const selects = screen.getAllByRole("combobox") as HTMLSelectElement[];
const unitSelect = selects.find((s) => s.value === "pc")!;
fireEvent.change(unitSelect, { target: { value: "year" } });
const lastCall = onChange.mock.calls[onChange.mock.calls.length - 1][0] as LineItemInput[];
expect(lastCall[0].unit).toBe("year");
});
});
// ── Totals calculation (edit mode) ────────────────────────────────────────────