|
|
c14a22588e
|
feat(crewing): Phase 5b — appraisal (flagged)
PR checks / checks (pull_request) Successful in 40s
PR checks / integration (pull_request) Successful in 30s
Final slice of Phase 5. The appraisal lifecycle raise → verify → approve across
three role-gated surfaces, per Crewing-Implementation-Spec §5.4/§8.14. Stacks on
5a verification. Behind NEXT_PUBLIC_CREWING_ENABLED. Completes Phase 5.
What's in
- Schema: Appraisal (on CrewAssignment) + AppraisalStatus
(DRAFT/SUBMITTED/MPO_VERIFIED/MANAGER_APPROVED/REJECTED); CrewActionType +=
APPRAISAL_SUBMITTED/VERIFIED/APPROVED/REJECTED. Migration crewing_appraisal.
- State machine lib/appraisal-state-machine.ts: verify (SUBMITTED→MPO_VERIFIED,
MPO/Manager), approve (MPO_VERIFIED→MANAGER_APPROVED, Manager); orthogonal reject.
- Actions (crewing/appraisals/actions.ts): raiseAppraisal (raise_appraisal — PM/
site staff), verifyAppraisal (verify_appraisal — MPO), approveAppraisal
(approve_appraisal — Manager); reject paths require remarks; notifications
APPRAISAL_FOR_VERIFICATION / APPRAISAL_FOR_APPROVAL.
- Three surfaces (§8.14): PM raises + tracks status on the crew-profile Appraisals
tab; MPO verifies in the Verification queue (Appraisals section); Manager approves
in the central /approvals queue (Appraisal kind).
Tests & docs
- Unit: appraisal-state-machine.test.ts (4). Integration: appraisal.test.ts (4) —
raise→verify→approve happy path, MPO reject, permission gating (MPO can't raise,
site staff can't verify, MPO can't approve). type-check clean; full unit (245) +
integration (205) green (verified with RESEND_API_KEY unset).
- CLAUDE.md updated — completes Phase 5 (I + H).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
2026-06-22 22:09:32 +05:30 |
|
|
|
8982118eee
|
feat(crewing): Phase 5a — verification queue (flagged)
PR checks / checks (pull_request) Successful in 41s
PR checks / integration (pull_request) Successful in 29s
First slice of Phase 5 (verification + appraisal). The office queue for verifying
site-entered records, per Crewing-Implementation-Spec §8.11/R11. Stacks on 4c.
Behind NEXT_PUBLIC_CREWING_ENABLED.
What's in
- Schema: CrewActionType += RECORD_VERIFIED/RECORD_REJECTED (migration
crewing_verification_actions). No model changes — SeafarerDocument/BankDetail/
EpfDetail already carry verificationStatus + verifiedById (3b/4a).
- Actions (crewing/verification/actions.ts): verifyDocument (verify_site_records —
MPO/Manager) and verifyBankEpf (verify_bank_epf — Accounts) set
verificationStatus VERIFIED/REJECTED + verifiedById; rejection requires remarks;
each writes a CrewAction. Already-decided records are guarded.
- Screen: /crewing/verification — role-aware (MPO: pending documents with expiry
flags; Accounts: pending bank/EPF), Verify / Reject-with-remarks. Leave is not
here (Manager approval, R11). Verification added to nav (MPO + Accounts + SU, §7).
Tests & docs
- Integration: verification.test.ts (6) — doc verify/reject + already-decided
guard, bank/EPF verify, permission gating (Accounts can't verify docs, MPO can't
verify bank/EPF). type-check clean; full unit (241) + integration (201) green
(verified with RESEND_API_KEY unset, mimicking CI).
- CLAUDE.md updated.
Deferred (per decision): PPE / next-of-kin verification gates.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
2026-06-22 21:59:31 +05:30 |
|
