2 commits

Author	SHA1	Message	Date
Hardik	d796e81efc	fix(crewing): harden onboardCandidate (D1 guard, D3 metadata, atomic contract) ... - D1: require a Manager-approved SalaryStructure before onboarding; a SELECTED application with none is now blocked instead of silently binding zero salary rows. - D3 AC2: the CREW_ONBOARDED CrewAction records the created IDs (assignmentId, employeeId, salaryStructureId) in metadata. - Atomicity: the contract letter is uploaded before the transaction and its row is created INSIDE it, so onboarding is one atomic write (no half-onboarded crew member without a contract on failure). onboarding.test.ts asserts the metadata and the new D1 block (no assignment, the candidate stays a CANDIDATE). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-06-22 23:32:30 +05:30
Hardik	c82efa71af	feat(crewing): Phase 3c — onboarding (flagged) ... Final slice of Phase 3 (stacked on 3b pipeline). The onboarding transaction that turns a SELECTED candidate into active crew, per Crewing-Implementation-Spec §8.5/§9/§11. Behind NEXT_PUBLIC_CREWING_ENABLED; production unchanged. What's in - Schema (crewing_onboarding migration): CrewAssignment + AssignmentStatus (ACTIVE/ON_LEAVE/SIGNED_OFF — leave/sign-off are Phase 4); ContractLetter (salaryRestricted); SalaryStructure += assignmentId; CrewActionType += CREW_ONBOARDED. Employee numbers CRW-xxxx via lib/employee-number.ts. - Action (onboardCandidate, onboard_crew): one transaction off a SELECTED application — assign employeeId, create CrewAssignment(ACTIVE, signOnDate), bind the approved SalaryStructure (assignmentId + effectiveFrom), Application → ONBOARDED, Requisition → FILLED, CrewMember → EMPLOYEE (+ currentRank); contract letter stored after. Guards flag + permission + SELECTED state. - Screen: the SELECTED action card's "Onboard to crew" modal (joining date, contract upload, starts-automatically chips); the CRW- number shows on the ONBOARDED card. Tests & docs - Integration: onboarding.test.ts (5) — full transaction, requisition FILLED + salary binding, joining-date + SELECTED-only guards, permission gating, sequential CRW- ids. type-check clean; full unit (234) + integration (168) green. - CLAUDE.md updated with the Phase 3c surface. Deferred: SITE_STAFF login creation for management ranks (grantsLogin) — a follow-up; attendance/experience/PPE records begin in Phase 4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-22 19:12:53 +05:30