shad0w/pelagia-portal
1
0
Fork 0
Code Issues 7 Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix(automation): issue watcher must not open PRs without tests #138

Merged
shad0w merged 1 commit from fix/watcher-test-gate into master 2026-06-25 22:24:54 +00:00
Conversation 0 Commits 1 Files changed 2 +21
shad0w commented 2026-06-25 22:23:34 +00:00
Owner
Copy link

PR #137 shipped a code change under App/app with no test — the test-presence
gate in pr-checks.yml would reject it, but the watcher opened the PR anyway.

Add the same gate to the watcher's fix phase: before pushing/opening a PR, run
the pr-checks.yml test-presence check against the branch diff. If code under
App/(app|lib|components|hooks) changed with no accompanying test, the watcher
does NOT open a PR — it marks the issue claude-failed and comments, so the
queue can retry. Never raises a PR the CI would immediately fail.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

PR #137 shipped a code change under App/app with no test — the test-presence gate in pr-checks.yml would reject it, but the watcher opened the PR anyway. Add the same gate to the watcher's fix phase: before pushing/opening a PR, run the pr-checks.yml test-presence check against the branch diff. If code under App/(app|lib|components|hooks) changed with no accompanying test, the watcher does NOT open a PR — it marks the issue claude-failed and comments, so the queue can retry. Never raises a PR the CI would immediately fail. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
shad0w added 1 commit 2026-06-25 22:23:34 +00:00
fix(automation): issue watcher must not open PRs without tests
All checks were successful
PR checks / checks (pull_request) Successful in 48s
Details
PR checks / integration (pull_request) Successful in 30s
Details
a5248e5c23 
PR #137 shipped a code change under App/app with no test — the test-presence
gate in pr-checks.yml would reject it, but the watcher opened the PR anyway.

Add the same gate to the watcher's fix phase: before pushing/opening a PR, run
the pr-checks.yml test-presence check against the branch diff. If code under
App/(app|lib|components|hooks) changed with no accompanying test, the watcher
does NOT open a PR — it marks the issue claude-failed and comments, so the
queue can retry. Never raises a PR the CI would immediately fail.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
shad0w merged commit 90a831790d into master 2026-06-25 22:24:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is broken

  
claude-failed

Automated fix attempt failed

  
claude-pr

Claude opened a PR for this

  
claude-queue

Queued for automated Claude fix

  
claude-working

Claude is working on this

  
epic

Crewing epic � tracking issue (A�M)

  
feature

New functionality

  
interactive

Run with Claude interactively/steered � not safe for the unattended watcher

  
portal

Reported via portal Report Issue button

  
triaged

Triage has run on this portal issue (prevents re-triage)

No labels
bug
claude-failed
claude-pr
claude-queue
claude-working
epic
feature
interactive
portal
triaged
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: shad0w/pelagia-portal#138
No description provided.
Delete branch "fix/watcher-test-gate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?