fix: Make GST captcha a popup #115

Merged

shad0w merged 1 commit from claude/issue-114 into master

2026-06-24 01:19:52 +00:00

shad0w commented

2026-06-24 01:07:42 +00:00

Owner

Automated fix by Claude Code for #114.

Closes #114

Review, merge, then create a release tag (vX.Y.Z) to deploy.

Automated fix by Claude Code for #114. Closes #114 Review, merge, then create a release tag (vX.Y.Z) to deploy.

shad0w added 1 commit 2026-06-24 01:07:42 +00:00

fix(vendors): move GSTIN CAPTCHA into a popup

PR checks / checks (pull_request) Successful in 46s

Details

PR checks / integration (pull_request) Successful in 31s

Details

55ae1d46d0

The GSTIN lookup rendered its CAPTCHA (image + 6-digit input + Verify /
New image) inline inside the Add/Edit Vendor dialog. AdminDialog has no
internal scroll and is vertically centred, so the taller form pushed its
footer (Cancel / Create Vendor / Save) off-screen and out of reach.

Extract the CAPTCHA into a dedicated popup (CaptchaPopup) overlaid on the
vendor form at z-[60] with an explicit Cancel button and a ✕ close
control. It handles Escape on the capture phase so dismissing the CAPTCHA
does not also close the underlying form. In-flight CAPTCHA errors now
show inside the popup (it stays open so the user can retry / get a new
image); the success line still lands on the main form. The form footer is
never displaced.

Adds a unit test covering popup open on Look up, Cancel closing only the
popup, and a successful verify populating the fields.

Fixes #114