ci: PR policy enforcement (tests + docs) and checks #36

Merged

shad0w merged 3 commits from ci/pr-checks into master

2026-06-19 07:37:40 +00:00

shad0w commented

2026-06-19 07:19:49 +00:00

Owner

Establishes the new contribution policy: all changes via PR, and every PR includes relevant docs + tests.

.forgejo/workflows/pr-checks.yml runs on every PR to master:
- hard: code PRs (App/app|lib|components|hooks) must include a test change
- hard: no new type errors in application code
- advisory: unit tests (baseline has 2 known failures); lint omitted (needs ESLint migration)
.forgejo/PULL_REQUEST_TEMPLATE.md — docs/tests checklist.
Autofix watcher now requires a test (issue-12 style) + doc updates in every fix PR.

Docs: automation/README.md > "Contribution policy".

Establishes the new contribution policy: **all changes via PR**, and every PR includes relevant docs + tests. - `.forgejo/workflows/pr-checks.yml` runs on every PR to master: - **hard**: code PRs (App/app|lib|components|hooks) must include a test change - **hard**: no new type errors in application code - advisory: unit tests (baseline has 2 known failures); lint omitted (needs ESLint migration) - `.forgejo/PULL_REQUEST_TEMPLATE.md` — docs/tests checklist. - Autofix watcher now requires a test (issue-12 style) + doc updates in every fix PR. Docs: automation/README.md > "Contribution policy".

shad0w added 1 commit 2026-06-19 07:19:50 +00:00

ci: enforce PR policy (tests-present + app type-check) and PR template

PR checks / checks (pull_request) Successful in 39s

Details

debac55a8a

All changes now land via PR. New .forgejo/workflows/pr-checks.yml runs on every PR
to master and (1) fails code PRs that lack a test change, (2) blocks new app-code type
errors. Unit tests are advisory until the baseline is green; lint is omitted (it needs
an interactive ESLint migration). PR template carries the docs/tests checklist.

Also makes the autofix watcher require a test (issue-12 style) + doc updates in every
fix, so its PRs satisfy the new gate.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

shad0w added 1 commit 2026-06-19 07:33:57 +00:00

test+ci: green the test baseline and make type-check + unit tests hard gates

PR checks / checks (pull_request) Successful in 30s

Details

938ff6df89

Green-lights the test suite so the PR checks can enforce it:
- Fix the NextAuth v5 auth() mock typing across all integration tests (cast to a
  simple async fn so mockResolvedValue accepts the session) — clears ~86 errors.
- Fix stale test values: intent 'resubmit'->'submit' / 'save'->'draft'; ParsedImportLine
  .description -> .name; approvepo -> approvePo; add missing beforeEach/beforeAll imports.
- permissions: MANAGER *can* process_payment (intentional since e1340b9) — update the
  stale assertion.
- po-import-parser: skip the Sample_PO.xlsx fixture tests when the file is absent (it
  lives outside the repo); synthetic-workbook tests still cover the parser.

type-check is now 0 errors and unit tests pass (167 passed, 13 skipped). pr-checks.yml
flips type-check (whole project) and unit tests to HARD gates.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

shad0w added 1 commit 2026-06-19 07:36:30 +00:00

Merge branch 'master' into ci/pr-checks

PR checks / checks (pull_request) Successful in 30s

Details

8406397602